Skip to content

/ forge

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Putting Docker Login password (base64 encoded) into forge.yaml is NO BUENO #11

Closed
plombardi89 opened this issue Jun 1, 2017 · 1 comment
Closed

Putting Docker Login password (base64 encoded) into forge.yaml is NO BUENO #11

plombardi89 opened this issue Jun 1, 2017 · 1 comment

Comments

@plombardi89
Copy link
Contributor

@plombardi89 plombardi89 commented Jun 1, 2017

I just committed my Docker Hub password to source control (in forge.yaml). Thankfully it's not a public repository and I can delete the source tree but that's really really bad.
@plombardi89 plombardi89 changed the title Putting Docker Login password (base64 encoded) into loom.yaml is NO BUENO Putting Docker Login password (base64 encoded) into forge.yaml is NO BUENO Jun 1, 2017
@rhs
Copy link
Contributor

@rhs rhs commented Jun 30, 2017

This file shouldn't ever need to be committed to github. It only contains global configuration (all service specific configuration is in service.yaml). I've added a big warning into the generated file that it contains secrets and that it should not be checked into github.
@rhs rhs closed this Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@rhs @plombardi89