Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPutting Docker Login password (base64 encoded) into forge.yaml is NO BUENO #11
Comments
plombardi89
changed the title from
Putting Docker Login password (base64 encoded) into loom.yaml is NO BUENO
to
Putting Docker Login password (base64 encoded) into forge.yaml is NO BUENO
Jun 1, 2017
This comment has been minimized.
This comment has been minimized.
|
This file shouldn't ever need to be committed to github. It only contains global configuration (all service specific configuration is in service.yaml). I've added a big warning into the generated file that it contains secrets and that it should not be checked into github. |
rhs
closed this
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
plombardi89 commentedJun 1, 2017
I just committed my Docker Hub password to source control (in
forge.yaml). Thankfully it's not a public repository and I can delete the source tree but that's really really bad.