New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails to pick up additional k8s directory. #183

Closed
pkim-auro opened this Issue Apr 26, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@pkim-auro

pkim-auro commented Apr 26, 2018

Maybe I am misusing the templating but found some wierd behavior:

Normal setup:
$REPO/k8s/deployment.yaml
actual result: forge build manifests -- works fine

Issue 1:
setup:
$REPO/k8s/forge-template/deployment.yaml

cmd: forge buildmanifets
expected result: will build using the template in forge-template/deployment.yaml
actual result: rendered: (none)

Issue 2:
setup:
$REPO/k8s/forge-template/deployment.yaml
$REPO/k8s/deployment.yaml

cmd: forge build manifets
expected result: will build something?
actual result: errors out:

║ 44 tasks run, 1 errors
║   None: unexpected error
║
║     Traceback (most recent call last):
║       File "/home/pkim/.pex/install/Forge-0.4.7-py2-none-any.whl.d3ef9c6c3e933bb5f7e07959f7f5e6a6322239a0/Forge-0.4.7-py2-none-any.whl/forge/core.py", line 327, in root
║         service.go(name)
║       File "/home/pkim/.pex/install/Forge-0.4.7-py2-none-any.whl.d3ef9c6c3e933bb5f7e07959f7f5e6a6322239a0/Forge-0.4.7-py2-none-any.whl/forge/core.py", line 320, in service
║         goal(svc)
║       File "/home/pkim/.pex/install/Forge-0.4.7-py2-none-any.whl.d3ef9c6c3e933bb5f7e07959f7f5e6a6322239a0/Forge-0.4.7-py2-none-any.whl/forge/core.py", line 240, in manifest
║         self.kube.label(k8s_dir, labels)
║       File "/home/pkim/.pex/install/Forge-0.4.7-py2-none-any.whl.d3ef9c6c3e933bb5f7e07959f7f5e6a6322239a0/Forge-0.4.7-py2-none-any.whl/forge/kubernetes.py", line 159, in label
║         self._labeltate(yaml_dir, labels, annotate=False)
║       File "/home/pkim/.pex/install/Forge-0.4.7-py2-none-any.whl.d3ef9c6c3e933bb5f7e07959f7f5e6a6322239a0/Forge-0.4.7-py2-none-any.whl/forge/kubernetes.py", line 139, in _labeltate
║         with open(os.path.join(yaml_dir, name), 'read') as f:
║     IOError: [Errno 21] Is a directory: u'/home/pkim/git/net-diagnostics/.forge/k8s/net-diagnostics/forge-template'
@rhs

This comment has been minimized.

Contributor

rhs commented Apr 26, 2018

This should be fixed in forge 0.4.10

@rhs rhs closed this Apr 26, 2018

@pkim-auro

This comment has been minimized.

pkim-auro commented Apr 27, 2018

Thanks Rafael. tested and working. logged a minor observation on #185 - maybe just documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment