New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a spec for service.yaml #22

Closed
rhs opened this Issue Jul 19, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@rhs
Contributor

rhs commented Jul 19, 2017

No description provided.

@tristanpemble

This comment has been minimized.

Contributor

tristanpemble commented Aug 28, 2017

This would be helpful for future proofing service.yaml; I feel weird putting my service-specific configuration at the top level since it may collide with configuration keys added to Forge in the future. A formal spec would help

@rhs rhs self-assigned this Aug 30, 2017

@rhs

This comment has been minimized.

Contributor

rhs commented Aug 31, 2017

I've added a schema and you can read the docs here: https://forge.sh/reference/service-descriptor

I'm open to any ideas on avoiding collision, e.g. we could define a reserved map or something:

service.yaml:
  name: ...
  config: # guaranteed to never be used by forge
    foo: bar
@rhs

This comment has been minimized.

Contributor

rhs commented Sep 14, 2017

I've added config to the schema as a reserved object.

@rhs rhs closed this Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment