Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge should respect .gitignore when computing hash #44

Closed
plombardi89 opened this issue Aug 31, 2017 · 1 comment
Closed

Forge should respect .gitignore when computing hash #44

plombardi89 opened this issue Aug 31, 2017 · 1 comment

Comments

@plombardi89
Copy link
Contributor

@plombardi89 plombardi89 commented Aug 31, 2017

Forge currently just uses the entire source tree but it really should respect the gitignore otherwise the hash will never be the same as the actual git hash for the source tree.

Not sure if there is a python implementation of the gitignore rules, but another option is to use the git command itself which offers powerful capabilities for inspecting ignored files:

https://stackoverflow.com/questions/466764/git-command-to-show-which-specific-files-are-ignored-by-gitignore

@rhs
Copy link
Contributor

@rhs rhs commented Sep 29, 2017

This is fixed in 0.3.1

@rhs rhs closed this Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants