New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameError: global name 'Github' is not defined #74

Closed
tristanpemble opened this Issue Oct 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@tristanpemble
Contributor

tristanpemble commented Oct 18, 2017

Running on macOS, happens on any release of 0.3.x

Running any forge build will trigger this:

║   None: unexpected error
║
║     Traceback (most recent call last):
║       File "/Users/tristanpemble/.pex/install/Forge-0.3.10-py2-none-any.whl.e92dbd34aa9cc738765511c6488a36021ae97c22/Forge-0.3.10-py2-none-any.whl/forge/cli.py", line 314, in root
║         for name in self.load_services():
║       File "/Users/tristanpemble/.pex/install/Forge-0.3.10-py2-none-any.whl.e92dbd34aa9cc738765511c6488a36021ae97c22/Forge-0.3.10-py2-none-any.whl/forge/cli.py", line 283, in load_services
║         services.extend(self.discovery.dependencies(services))
║       File "/Users/tristanpemble/.pex/install/Forge-0.3.10-py2-none-any.whl.e92dbd34aa9cc738765511c6488a36021ae97c22/Forge-0.3.10-py2-none-any.whl/forge/service.py", line 154, in dependencies
║         if not self.resolve(svc, r): missing.append(r)
║       File "/Users/tristanpemble/.pex/install/Forge-0.3.10-py2-none-any.whl.e92dbd34aa9cc738765511c6488a36021ae97c22/Forge-0.3.10-py2-none-any.whl/forge/service.py", line 128, in resolve
║         gh = Github(None)
║     NameError: global name 'Github' is not defined

rhs added a commit that referenced this issue Oct 20, 2017

rhs added a commit that referenced this issue Oct 23, 2017

@rhs

This comment has been minimized.

Contributor

rhs commented Oct 23, 2017

I was able to reproduce this locally, and I believe it should be fixed now in 0.3.11. Please refile/reopen if this shows up again.

@rhs rhs closed this Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment