Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Hungarian translation #1001

Closed
balazsorban44 opened this issue Dec 6, 2018 · 4 comments 路 Fixed by #1002

Comments

@balazsorban44
Copy link

commented Dec 6, 2018

Moving it to a new issue from #844 for clarification. @TwoDCube, @reyrodrigez did you guys work on the translations? If so, could you have a look at this?

I am using the HU 馃嚟馃嚭 locale, and unfortunately, it gives a grammatically wrong result:

formatDistance(
    new Date('A date that is 2 days ago'),
    new Date(),
    {locale: hu, addSuffix: true}
)
// => 2 napja ezel艖tt
// Correct: 2 napja or 2 nappal ezel艖tt

I am using date-fns@next

@TwoDCube

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2018

Hi! I've opened a PR for this. What do you think?

formatDistance(
    new Date('A date that is 2 days ago'),
    new Date(),
    {locale: hu, addSuffix: true}
)
// => 2 nappal ezel艖tt

formatDistance(
    new Date('A date that is 2 days ago'),
    new Date(),
    {locale: hu, addSuffix: false}
)
// => 2 napja
@balazsorban44

This comment has been minimized.

Copy link
Author

commented Dec 6, 2018

Looks like it would work! 馃憣 waiting for merge. 馃檪

@reyrodrigez

This comment has been minimized.

Copy link

commented Dec 7, 2018

thanks @TwoDCube, greatjob!

kossnocorp added a commit that referenced this issue Dec 10, 2018
@kossnocorp

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

This fix for the issue was released with v2.0.0-alpha.26. See: https://blog.date-fns.org/post/v200-alpha26-is-out-2rizgx9wk2g1t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can鈥檛 perform that action at this time.