Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Hungarian translation #1001

Closed
balazsorban44 opened this issue Dec 6, 2018 · 4 comments · Fixed by #1002
Closed

Error in Hungarian translation #1001

balazsorban44 opened this issue Dec 6, 2018 · 4 comments · Fixed by #1002

Comments

@balazsorban44
Copy link

Moving it to a new issue from #844 for clarification. @TwoDCube, @reyrodrigez did you guys work on the translations? If so, could you have a look at this?

I am using the HU 🇭🇺 locale, and unfortunately, it gives a grammatically wrong result:

formatDistance(
    new Date('A date that is 2 days ago'),
    new Date(),
    {locale: hu, addSuffix: true}
)
// => 2 napja ezelőtt
// Correct: 2 napja or 2 nappal ezelőtt

I am using date-fns@next

@TwoDCube
Copy link
Member

TwoDCube commented Dec 6, 2018

Hi! I've opened a PR for this. What do you think?

formatDistance(
    new Date('A date that is 2 days ago'),
    new Date(),
    {locale: hu, addSuffix: true}
)
// => 2 nappal ezelőtt

formatDistance(
    new Date('A date that is 2 days ago'),
    new Date(),
    {locale: hu, addSuffix: false}
)
// => 2 napja

@balazsorban44
Copy link
Author

Looks like it would work! 👌 waiting for merge. 🙂

@reyrodrigez
Copy link

thanks @TwoDCube, greatjob!

@kossnocorp
Copy link
Member

This fix for the issue was released with v2.0.0-alpha.26. See: https://blog.date-fns.org/post/v200-alpha26-is-out-2rizgx9wk2g1t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants