New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format functions must throw exceptions on attempt on processing invalid dates #987

Closed

kossnocorp opened this issue Nov 20, 2018 · 0 comments

Labels

🌟 Improvement 😈 Breaking

Milestone

Member

kossnocorp commented Nov 20, 2018 •

edited by leshakoss

See JavaScript's toISOString and Intl API for the reasoning:

const date = new Date()

date.setHours('nope')
//=> NaN

date.getYear()
//=> NaN

date.toString()
//=> Invalid date

date.toISOString()
//=> RangeError: Invalid time value

new Intl.DateTimeFormat('en-US').format(date)
//=> RangeError: Invalid time value

kossnocorp added the 🌟 Improvement label

kossnocorp added this to the v2 beta milestone

kossnocorp mentioned this issue

format returns "undefined NaN, 0NaN" for invalid dates #304

Closed

kossnocorp added the 😈 Breaking label

kossnocorp closed this in

a239752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.