Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DST issue (closes #972, closes #992) #1003

Merged
merged 8 commits into from Dec 10, 2018
Merged

Fix DST issue (closes #972, closes #992) #1003

merged 8 commits into from Dec 10, 2018

Conversation

@kossnocorp
Copy link
Member

@kossnocorp kossnocorp commented Dec 7, 2018

Rework approach to DST handling to make it more bulletproof.

To do:

Remove code that causes #972. Most likely it will break something else,
but this is yet to figure.
@kossnocorp kossnocorp changed the title Fix DST issue (closes #972) Fix DST issue (closes #972, closes #992) Dec 7, 2018
@kossnocorp kossnocorp merged commit efdbf3b into master Dec 10, 2018
1 check passed
Loading
@kossnocorp kossnocorp deleted the 972-dst-bug branch Dec 10, 2018
kossnocorp added a commit that referenced this issue Dec 10, 2018
kossnocorp added a commit that referenced this issue Dec 10, 2018
kossnocorp added a commit that referenced this issue Dec 10, 2018
@kronthto
Copy link

@kronthto kronthto commented Oct 26, 2019

I think taking the next day into consideration causes weird behaviour in some cases. See:

// import dateformat from 'date-fns/format'

> dateformat('2019-10-26T22:40:00')
"2019-10-26T23:40:00.000+02:00"

(format calling parse)
It makes 23:40 out of 22:40.

date-fns version: 1.30.1 - this change was backported there.

This is with a Europe/Berlin Browser/system timezone, we have DST change at 2019-10-27 03:00 (the day after that date).

Sorry if this was already reported/fixed elsewhere, or I'm wrong / this is intended. Tbh. I didn't put too much effort into tracking it down further but it lead me here and I wanted to report it.

Yep I see there is already #1500 so ignore this.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants