Fix DST issue (closes #972, closes #992) #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code that causes #972. Most likely it will break something else, but this is yet to figure.
kossnocorp
force-pushed
the
972-dst-bug
branch
from
4ba1745 to
7150665
Compare
kossnocorp
changed the title
kossnocorp
added a commit
that referenced
this pull request
Dec 10, 2018
kossnocorp
added a commit
that referenced
this pull request
Dec 10, 2018
kossnocorp
added a commit
that referenced
this pull request
Dec 10, 2018
|
I think taking the next day into consideration causes weird behaviour in some cases. See: // import dateformat from 'date-fns/format'
> dateformat('2019-10-26T22:40:00')
"2019-10-26T23:40:00.000+02:00"( date-fns version: 1.30.1 - this change was backported there. This is with a Europe/Berlin Browser/system timezone, we have DST change at 2019-10-27 03:00 (the day after that date). Sorry if this was already reported/fixed elsewhere, or I'm wrong / this is intended. Tbh. I didn't put too much effort into tracking it down further but it lead me here and I wanted to report it. Yep I see there is already #1500 so ignore this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework approach to DST handling to make it more bulletproof.
To do: