Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Flemish short date format #2535

Merged
merged 2 commits into from Jul 29, 2021
Merged

Adjust Flemish short date format #2535

merged 2 commits into from Jul 29, 2021

Conversation

@call-a3
Copy link
Contributor

@call-a3 call-a3 commented Jun 28, 2021

As per the recommendation of the flemish government, documented at https://www.vlaanderen.be/taaladvies/datumnotatie

As per the recommendation of the flemish government, documented at https://www.vlaanderen.be/taaladvies/datumnotatie
@tan75 tan75 requested a review from Jun 28, 2021
@tan75
Copy link
Contributor

@tan75 tan75 commented Jun 28, 2021

Hello @date-fns/i18n-nl-be
could you please double-check and approve this PR?
Many thanks!

@tan75 tan75 self-assigned this Jun 28, 2021
@DCBN
Copy link
Contributor

@DCBN DCBN commented Jun 29, 2021

The change checks out to me, just fix the failing tests and I'll approve.

@tan75
Copy link
Contributor

@tan75 tan75 commented Jul 28, 2021

The change checks out to me, just fix the failing tests and I'll approve.

The tests have been fixed. Please approve this PR.

@tan75 tan75 self-requested a review Jul 28, 2021
tan75
tan75 approved these changes Jul 28, 2021
Copy link
Contributor

@tan75 tan75 left a comment

Thank you! 👍

DCBN
DCBN approved these changes Jul 28, 2021
Copy link
Contributor

@DCBN DCBN left a comment

Looks good, well done!

@kossnocorp kossnocorp merged commit 4449d2b into date-fns:master Jul 29, 2021
4 checks passed
@kossnocorp kossnocorp mentioned this pull request Aug 19, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants