Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the number 1 instead of the word "ein" for formatDuration in German locale #2576

Merged
merged 5 commits into from Sep 17, 2021

Conversation

@janziemba
Copy link
Contributor

@janziemba janziemba commented Aug 5, 2021

Fixes #2505

@tan75
Copy link
Contributor

@tan75 tan75 commented Sep 11, 2021

@date-fns/i18n-de
@date-fns/i18n-de-at
Could you please approve this PR?

@pex
Copy link
Member

@pex pex commented Sep 12, 2021

I just left a comment on #2505 to provide some context.
Personally I would not approve this change, although I see cases where the current behaviour can become impractical.
In terms of implementation it's well done, though. Thank you @janziemba!

@kossnocorp kossnocorp merged commit 32270fe into date-fns:master Sep 17, 2021
4 checks passed
@janziemba janziemba deleted the fix/de-locale-ein-to-1 branch Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants