Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes formatDuration with Norwegian Locale Consistent with others #2631

Conversation

@LucasHFS
Copy link
Contributor

@LucasHFS LucasHFS commented Sep 13, 2021

attempt to solve #2469

@LucasHFS LucasHFS force-pushed the 2469/makes-formatDuration-norwegian-consistent branch from 9967b98 to 043662d Sep 13, 2021
@tan75
Copy link
Contributor

@tan75 tan75 commented Sep 14, 2021

@date-fns/i18n-nb
Hi,
could you please have a look?

@tan75 tan75 linked an issue that may be closed by this pull request Sep 14, 2021
Copy link
Contributor

@kbrabrand kbrabrand left a comment

Looks good to me 👍

@tan75 tan75 mentioned this pull request Sep 15, 2021
16 tasks
tan75
tan75 approved these changes Sep 15, 2021
Copy link
Contributor

@tan75 tan75 left a comment

Thank you! 🙏

@kossnocorp kossnocorp merged commit c5a0adc into date-fns:master Sep 17, 2021
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants