Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean language support (ko) #327

Merged
merged 1 commit into from Dec 12, 2016

Conversation

@angdev
Copy link
Member

angdev commented Dec 10, 2016

Thanks for great library, but there weren't any korean translation yet. Here's my contribution.

FYI: I referenced moment ko locale, rails ko locale, and python arrow ko locale for this work.

Copy link
Member

kossnocorp left a comment

Amazing! Please fix JSDoc and we're good to go!

/**
* @category Locales
* @summary English locale.
*/

This comment has been minimized.

Copy link
@kossnocorp

This comment has been minimized.

Copy link
@angdev

angdev Dec 12, 2016

Author Member

Oh, I missed it. Nice review 👍

@angdev angdev force-pushed the angdev:korean-language-support branch from 721bf6b to b266a92 Dec 12, 2016
@angdev

This comment has been minimized.

Copy link
Member Author

angdev commented Dec 12, 2016

@kossnocorp Fixed it! New commit with amending.

Copy link
Contributor

leshakoss left a comment

@angdev thank you!

@leshakoss leshakoss merged commit f1d1515 into date-fns:master Dec 12, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leshakoss

This comment has been minimized.

Copy link
Contributor

leshakoss commented Dec 12, 2016

@angdev thanks for your awesome contribution! ⭐️ Korean locale was released with 1.18.0 (diff: v1.17.0...v1.18.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.