Repository navigation
Add BE locale - #716
Merged
Merged
Add BE locale#716
Conversation
Contributor
|
I was a little confused by this PR since |
Member
|
@mrenty ISO 639-1 code for belorusian is |
Member
|
Same as with Serbian: I'm going to release it soon. |
SpadarShut
reviewed
Dec 10, 2018
| function buildDistanceInWordsLocale () { | ||
| var distanceInWordsLocale = { | ||
| lessThanXSeconds: { | ||
| one: 'менш секунды', |
Member
There was a problem hiding this comment.
@SpadarShut thanks, is there's anything else to improve?
There was a problem hiding this comment.
Is there a way to have multiple plurals, not just one-many?
Member
There was a problem hiding this comment.
Member
|
That's ok, this localization requires proper plurals which is a fair bit of
work and requires a PR anyway.
…On Mon, Dec 10, 2018 at 4:40 PM Sasha Koss ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/locale/be/build_distance_in_words_locale/index.js
<#716 (comment)>:
> @@ -0,0 +1,99 @@
+function buildDistanceInWordsLocale () {
+ var distanceInWordsLocale = {
+ lessThanXSeconds: {
+ one: 'менш секунды',
I appreciate the effort, but I can't work with incomplete suggestions.
Also regarding "менш за секунду", Google shows more results for "менш
секунды":
[image: image 2018-12-10 at 7 08 39 pm]
<https://user-images.githubusercontent.com/52201/49736065-1b29ca00-fcaf-11e8-8f52-a8dc71f2bdfa.png>
[image: image 2018-12-10 at 7 08 22 pm]
<https://user-images.githubusercontent.com/52201/49736071-1ebd5100-fcaf-11e8-9bf0-27b380abaa15.png>
If you think it's wrong, please open PR. I can't wait for your answer, so
I'm going to release as is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#716 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAtFlhjpfdcFJsJV7M7E5aGCSuXh9-ebks5u3mRLgaJpZM4SzU45>
.
|
kossnocorp
pushed a commit
that referenced
this pull request
Dec 10, 2018
Member
|
The locale was released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Add BE locale (#703)