Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BE locale #716

Merged
merged 1 commit into from Dec 10, 2018

Conversation

@mawi12345
Copy link

commented Mar 21, 2018

Add BE locale (#703)

@mawi12345 mawi12345 changed the title add BE locale (#703) add BE locale Mar 21, 2018

@mawi12345 mawi12345 changed the title add BE locale Add BE locale Mar 21, 2018

@mrenty

This comment has been minimized.

Copy link

commented Mar 29, 2018

I was a little confused by this PR since BE is the land code of Belgium. I think you mean BY for Belarus.

@leshakoss

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

@mrenty ISO 639-1 code for belorusian is be. We use language codes, not country codes

@kossnocorp kossnocorp merged commit 2e66773 into date-fns:v1 Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kossnocorp

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Same as with Serbian: I'm going to release it soon.

function buildDistanceInWordsLocale () {
var distanceInWordsLocale = {
lessThanXSeconds: {
one: 'менш секунды',

This comment has been minimized.

Copy link
@SpadarShut

SpadarShut Dec 10, 2018

Should be "менш за секунду"

This comment has been minimized.

Copy link
@kossnocorp

kossnocorp Dec 10, 2018

Member

@SpadarShut thanks, is there's anything else to improve?

This comment has been minimized.

Copy link
@SpadarShut

SpadarShut Dec 10, 2018

Is there a way to have multiple plurals, not just one-many?

This comment has been minimized.

Copy link
@kossnocorp

kossnocorp Dec 10, 2018

Member

I appreciate the effort, but I can't work with incomplete suggestions. Also regarding "менш за секунду", Google shows more results for "менш секунды":

image 2018-12-10 at 7 08 39 pm

image 2018-12-10 at 7 08 22 pm

If you think it's wrong, please open PR. I can't wait for your answer, so I'm going to release as is.

@SpadarShut

This comment has been minimized.

Copy link

commented Dec 10, 2018

kossnocorp added a commit that referenced this pull request Dec 10, 2018
@kossnocorp

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

The locale was released with v1.30.1. See: https://blog.date-fns.org/post/v130-is-out-m35nqh4m13r7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.