New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BE locale #716
Add BE locale #716
Conversation
I was a little confused by this PR since |
@mrenty ISO 639-1 code for belorusian is |
Same as with Serbian: I'm going to release it soon. |
function buildDistanceInWordsLocale () { | ||
var distanceInWordsLocale = { | ||
lessThanXSeconds: { | ||
one: 'менш секунды', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "менш за секунду"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SpadarShut thanks, is there's anything else to improve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to have multiple plurals, not just one-many?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's ok, this localization requires proper plurals which is a fair bit of
work and requires a PR anyway.
…On Mon, Dec 10, 2018 at 4:40 PM Sasha Koss ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/locale/be/build_distance_in_words_locale/index.js
<#716 (comment)>:
> @@ -0,0 +1,99 @@
+function buildDistanceInWordsLocale () {
+ var distanceInWordsLocale = {
+ lessThanXSeconds: {
+ one: 'менш секунды',
I appreciate the effort, but I can't work with incomplete suggestions.
Also regarding "менш за секунду", Google shows more results for "менш
секунды":
[image: image 2018-12-10 at 7 08 39 pm]
<https://user-images.githubusercontent.com/52201/49736065-1b29ca00-fcaf-11e8-8f52-a8dc71f2bdfa.png>
[image: image 2018-12-10 at 7 08 22 pm]
<https://user-images.githubusercontent.com/52201/49736071-1ebd5100-fcaf-11e8-9bf0-27b380abaa15.png>
If you think it's wrong, please open PR. I can't wait for your answer, so
I'm going to release as is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#716 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAtFlhjpfdcFJsJV7M7E5aGCSuXh9-ebks5u3mRLgaJpZM4SzU45>
.
|
The locale was released with |
Add BE locale (#703)