Skip to content

Add BE locale - #716

Merged
kossnocorp merged 1 commit into
date-fns:v1from
bizquiz:v1-be
Dec 10, 2018
Merged

kossnocorp merged 1 commit into
date-fns:v1from
bizquiz:v1-be

Conversation

@mawi12345

@mawi12345 mawi12345 commented Mar 21, 2018 •

Copy link
Copy Markdown

Add BE locale (#703)

@mawi12345 mawi12345 changed the title add BE locale (#703) add BE locale Mar 21, 2018
@mawi12345 mawi12345 changed the title add BE locale Add BE locale Mar 21, 2018
@mrenty

mrenty commented Mar 29, 2018

Copy link
Copy Markdown
Contributor

I was a little confused by this PR since BE is the land code of Belgium. I think you mean BY for Belarus.

@leshakoss

Copy link
Copy Markdown
Member

@mrenty ISO 639-1 code for belorusian is be. We use language codes, not country codes

@kossnocorp
kossnocorp merged commit 2e66773 into date-fns:v1 Dec 10, 2018
@kossnocorp

Copy link
Copy Markdown
Member

Same as with Serbian: I'm going to release it soon.

function buildDistanceInWordsLocale () {
var distanceInWordsLocale = {
lessThanXSeconds: {
one: 'менш секунды',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "менш за секунду"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpadarShut thanks, is there's anything else to improve?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to have multiple plurals, not just one-many?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort, but I can't work with incomplete suggestions. Also regarding "менш за секунду", Google shows more results for "менш секунды":

image 2018-12-10 at 7 08 39 pm

image 2018-12-10 at 7 08 22 pm

If you think it's wrong, please open PR. I can't wait for your answer, so I'm going to release as is.

@SpadarShut

SpadarShut commented Dec 10, 2018 via email

Copy link
Copy Markdown

kossnocorp pushed a commit that referenced this pull request Dec 10, 2018
@kossnocorp

Copy link
Copy Markdown
Member

The locale was released with v1.30.1. See: https://blog.date-fns.org/post/v130-is-out-m35nqh4m13r7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants