Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BE locale #716

Merged
merged 1 commit into from Dec 10, 2018
Merged

Add BE locale #716

merged 1 commit into from Dec 10, 2018

Conversation

@mawi12345
Copy link

@mawi12345 mawi12345 commented Mar 21, 2018

Add BE locale (#703)

@mawi12345 mawi12345 changed the title add BE locale (#703) add BE locale Mar 21, 2018
@mawi12345 mawi12345 changed the title add BE locale Add BE locale Mar 21, 2018
@mrenty
Copy link
Contributor

@mrenty mrenty commented Mar 29, 2018

I was a little confused by this PR since BE is the land code of Belgium. I think you mean BY for Belarus.

Loading

@leshakoss
Copy link
Contributor

@leshakoss leshakoss commented Mar 29, 2018

@mrenty ISO 639-1 code for belorusian is be. We use language codes, not country codes

Loading

@kossnocorp kossnocorp merged commit 2e66773 into date-fns:v1 Dec 10, 2018
1 check passed
Loading
@kossnocorp
Copy link
Member

@kossnocorp kossnocorp commented Dec 10, 2018

Same as with Serbian: I'm going to release it soon.

Loading

function buildDistanceInWordsLocale () {
var distanceInWordsLocale = {
lessThanXSeconds: {
one: 'менш секунды',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "менш за секунду"

Loading

Copy link
Member

@kossnocorp kossnocorp Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpadarShut thanks, is there's anything else to improve?

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to have multiple plurals, not just one-many?

Loading

Copy link
Member

@kossnocorp kossnocorp Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

Copy link
Member

@kossnocorp kossnocorp Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort, but I can't work with incomplete suggestions. Also regarding "менш за секунду", Google shows more results for "менш секунды":

image 2018-12-10 at 7 08 39 pm

image 2018-12-10 at 7 08 22 pm

If you think it's wrong, please open PR. I can't wait for your answer, so I'm going to release as is.

Loading

@SpadarShut
Copy link

@SpadarShut SpadarShut commented Dec 10, 2018

Loading

kossnocorp added a commit that referenced this issue Dec 10, 2018
@kossnocorp
Copy link
Member

@kossnocorp kossnocorp commented Dec 11, 2018

The locale was released with v1.30.1. See: https://blog.date-fns.org/post/v130-is-out-m35nqh4m13r7

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants