Improve ja translation of distanceInWords #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudohamu
force-pushed
the
improve-ja-translation-of-distance-in-words
branch
3 times, most recently
from
d395fdd to
7ba5da3
Compare
kudohamu
force-pushed
the
improve-ja-translation-of-distance-in-words
branch
from
7ba5da3 to
7705a1a
Compare
kossnocorp
pushed a commit
that referenced
this pull request
Oct 1, 2018
Member
|
Thank you! I'll ship the change with a new v1 version. |
kossnocorp
pushed a commit
that referenced
this pull request
Dec 10, 2018
Member
|
The fix for the locale was released with Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a unnatural japanese translation of
distanceInWordsof v1.Currently,
almostXYearswith a suffix is translated into JapaneseX年以下前, but this expression is not used by Japanese.So I changed it to be
X年ぐらい前which is a natural Japanese translation.formatDistancehas a same problem, so if this PR is merged, I will also create PR forformatDistanceto master branch :)