Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ja translation of distanceInWords #880

Merged

Conversation

@kudohamu
Copy link
Contributor

commented Sep 20, 2018

I fixed a unnatural japanese translation of distanceInWords of v1.
Currently, almostXYears with a suffix is translated into Japanese X年以下前, but this expression is not used by Japanese.
So I changed it to be X年ぐらい前 which is a natural Japanese translation.

formatDistance has a same problem, so if this PR is merged, I will also create PR for formatDistance to master branch :)

@kudohamu kudohamu force-pushed the kudohamu:improve-ja-translation-of-distance-in-words branch 3 times, most recently from d395fdd to 7ba5da3 Sep 20, 2018

@kudohamu kudohamu force-pushed the kudohamu:improve-ja-translation-of-distance-in-words branch from 7ba5da3 to 7705a1a Sep 21, 2018

kossnocorp added a commit that referenced this pull request Oct 1, 2018

@kossnocorp kossnocorp merged commit f126d25 into date-fns:v1 Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kossnocorp

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Thank you! I'll ship the change with a new v1 version.

@kossnocorp

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

The fix for the locale was released with v1.30.1. See: https://blog.date-fns.org/post/v130-is-out-m35nqh4m13r7

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.