Update Indonesian locale for v2 - #983
Merged
Merged
Conversation
kossnocorp
approved these changes
Nov 14, 2018
kossnocorp
left a comment
kossnocorp
left a comment
Member
There was a problem hiding this comment.
Thanks a lot! I'm going to ship it soon 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #914
In this PR, I have updated the Indonesian locale in
^v2.0.0-alpha.20to correctly use Gregorian CLDR standard, as well as following the existing patterns (I usedlocale/en-USas the baseline, both for the functions and the tests). I modified the tests so it will match the Indonesian locale implementation.To ensure I'm doing the right thing, I did these 2 below:
yarn testin my local, all tests passed.date-fnswith Indonesian locale. Theformatfunction which throws an error before, now it is working as intended.