Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Indonesian locale for v2 #983

merged 3 commits into from Nov 14, 2018

Update Indonesian locale for v2 #983

merged 3 commits into from Nov 14, 2018


Copy link

@imballinst imballinst commented Nov 11, 2018

Fixes #914

In this PR, I have updated the Indonesian locale in ^v2.0.0-alpha.20 to correctly use Gregorian CLDR standard, as well as following the existing patterns (I used locale/en-US as the baseline, both for the functions and the tests). I modified the tests so it will match the Indonesian locale implementation.

To ensure I'm doing the right thing, I did these 2 below:

  1. Executed yarn test in my local, all tests passed.
  2. Packaged my forked repo to one of my projects that use date-fns with Indonesian locale. The format function which throws an error before, now it is working as intended.

Copy link

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I'm going to ship it soon 🙏

@kossnocorp kossnocorp merged commit 7429e34 into date-fns:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants