Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Future Publishing Limited' (community contribution) #1153

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit

@fm
Copy link
Collaborator

fm commented Jun 25, 2021

Future plc owns 163 brands... I'll see if I can get a list and add them all (unless we don't really need to @baltpeter?)

@baltpeter
Copy link
Member

163 brands? :o Wow. From a quick glance, it seems like they do indeed all list Future as the controller. As such, I do think it would be helpful to list them under runs.

One thing to note: I am currently working on regular automatic verification of whether our records are still up-to-date (see #1158). I would also like to include the runs list in that verification as sometimes services are sold to another company etc. But I am not sure yet if that is really feasible. For that, we'd need to have sources that list all the runs items so they can automatically be checked.
In this particular case, the brands page unfortunately doesn't include the names but only the logos and a slug (included in the URL)…

@baltpeter baltpeter self-assigned this Nov 7, 2021
@baltpeter baltpeter force-pushed the suggest_futureplc_1624298279063 branch from ef03723 to 7d9edf3 Compare November 7, 2021 17:13
@baltpeter
Copy link
Member

baltpeter commented Nov 7, 2021

163 brands? :o Wow.

Well, nothing a few lines of JS scraping code can't fix. :D And congrats to Future plc for being the longest and most ridiculous record we have (so far…).

Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit c0726c3 into datenanfragen:master Nov 7, 2021
@baltpeter baltpeter deleted the suggest_futureplc_1624298279063 branch November 7, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants