Add 'Sparkasse Hannover' (community contribution)

[datenanfragen-community-edits]

This suggestion was submitted through the website.

Edit

[WebworkrNet]

I have opened this issue via datenanfragen.de.
You can contact me if you have any questions.

[WebworkrNet]

It should of course be Sparkasse Hannover instead of Sparkasse Sparkasse.

I tried to change this in the editor, but failed at the final save. What do I have to do so that the updated values are transferred to the file?

[fm]

Do you mean the company editor on datarequests.org or the builder at https://company-json.datenanfragen.de? If the latter, you need to click on Generate after each change.

[WebworkrNet]

the builder at https://company-json.datenanfragen.de? If the latter, you need to click on Generate after each change.

Hm, don't know what went wrong. Thanks for the info, will try again next time.

[mal-tee]

If you tried to commit to this Pull Request, then it didn't work because only maintainers can update records suggested through datenanfragen.de/suggest. As the repository/branch is owned by our https://github.com/datenanfragen-community-edits bot.

Because you are a recurring suggester, I recommend filing PRs yourself through your own Github-Account. That would allow you to submit multiple records at once and update your own records according to our review or our tests. You also wouldn't need to notify us that you made this PR. (If you need another incentive: We will host another Hacktoberfest event, like last year. Filing PRs yourself and registering to our event will give you a chance to win goodies. :) )

Our typical workflow to add new companies is using company-json.datenanfragen.de, downloading the files and then committing them to git. Either through GitHub, e.g. go to the companies folder and click this button:

or use your favorite git client to add a new company. Committing through GitHub will create a so-called fork on your Github-Account, so to say a working copy for you.

If you want to use another client, you'll have to fork the repository first and then commit to that fork on your account. If you want to know more, there are plenty of guides online on working with git and GitHub.

After you've made your changes to your fork, you can create a Pull Request. GitHub will show a handy button on top of the repository.

The company-json.datenanfragen.de tool is a bit more complex than /suggest, but offers some advanced features, for example integrated tests. If you encounter new or weird fields, just ignore them, you don't have to fill them. For example, we rarely use "needs-id-document", that why we don't show it in our /suggest-interface.

[WebworkrNet]

Could someone rename the title of the PR to Sparkasse Hannover? Thanks

[baltpeter]

Sure, done.

[WebworkrNet]

@mal-tee Thank you for the detailed explanations, now I see more clearly.

Own PRs are an interesting alternative for later. At the moment I'm on the road with a mobile device. I think the generator via the website is the better option at the moment.

My question by e-mail is answered. :-)