Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Internet TV AG' (community contribution) #1350

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit

@WebworkrNet
Copy link
Contributor

I have opened this issue via datenanfragen.de.
You can contact me if you have any questions.

Copy link
Contributor

@moriarty-jim moriarty-jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed address and suggestion for relevant-countries (optional)

companies/onlinetvrecorder.json Outdated Show resolved Hide resolved
companies/onlinetvrecorder.json Outdated Show resolved Hide resolved
baltpeter and others added 2 commits October 2, 2021 10:59
Co-authored-by: moriarty-jim <73719894+moriarty-jim@users.noreply.github.com>
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everyone!

@baltpeter baltpeter merged commit 6fecbf8 into datenanfragen:master Oct 2, 2021
@baltpeter baltpeter deleted the suggest_onlinetvrecorder_1632928537018 branch October 2, 2021 09:01
@WebworkrNet
Copy link
Contributor

@baltpeter

  • Recommended medium "Email"
    Removed because the record was not marked as "tested"?

  • Reference to expensive international telephone number
    Removed because it is not a special call number?

@fm
Copy link
Collaborator

fm commented Oct 14, 2021

Recommended medium "Email"
Removed because the record was not marked as "tested"?

No, because it's not a privacy specific email.

@baltpeter
Copy link
Member

* **Reference to expensive international telephone number**
  Removed because it is not a special call number?

Exactly. I'm really not a fan of having unstructured non-machine-readable data in the comments and in addition, they are also really hard to internationalize. Special rate numbers are an exception where I think the value of the warning outweighs the downsides. But defining an "international" number isn't so easy since all records are displayed on all our language versions and for all countries. And since we are always displaying phone numbers with the full international prefix, this should hopefully be obvious to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

5 participants