New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Fleurop AG' (community contribution) #1498
Add 'Fleurop AG' (community contribution) #1498
Conversation
f067db8
to
07a6c9c
Compare
This dataset can be marked as "
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WebworkrNet! I've updated your suggestion according to your feedback from testing. required-elements lists all personal data that needs to be provided. needs-id-document is set to true when a copy of an ID document must be submitted.
Co-authored-by: moriarty-jim <73719894+moriarty-jim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, all!
|
Ignore that last revert commit |
|
I miss the obligatory copy of the ID card in the data set. |
But it's set correctly: Line 33 in ac0aca1
|
|
@baltpeter |
|
Yes, currently that field isn't used anywhere by the website. The reason is that we're planning to add support for attaching ID documents directly in our generator but haven't gotten around that yet. Now you might say that we could just display a hint in the meantime but we would consider that to be dangerous. Even in the (relative rare) cases where it is legal for a controller to require an ID document for verification, it is never legal to require the full document. There will always be values on the ID document that can (and absolutely should) be redacted by the user. We will only start displaying a hint like that once we also have data on which values on the ID document can be redacted, so we can display that alongside the hint. But to be honest, this feature is pretty low on our priority list at the moment. Our interpretation of the law is that a controller may only require an ID copy in rare cases. |
This suggestion was submitted through the website.
Edit