Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Fleurop AG' (community contribution) #1498

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit

@WebworkrNet
Copy link
Contributor

This dataset can be marked as "tested".

Personal data provided at data request:

  • Email address
  • Name
  • Address
  • Birth date
  • Other

Evidence requested to confirm identity:

  • No provision of evidence
  • Requests by email must be made from the same email address that is the subject of the request. This should be noted if the submitted address is an email forwarding address.
  • Birth date
  • Copy of ID

Copy link
Contributor

@moriarty-jim moriarty-jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WebworkrNet! I've updated your suggestion according to your feedback from testing. required-elements lists all personal data that needs to be provided. needs-id-document is set to true when a copy of an ID document must be submitted.

companies/fleurop.json Outdated Show resolved Hide resolved
companies/fleurop.json Outdated Show resolved Hide resolved
Co-authored-by: moriarty-jim <73719894+moriarty-jim@users.noreply.github.com>
Copy link
Collaborator

@fm fm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, all!

@fm fm merged commit 0a1076e into datenanfragen:master Oct 24, 2021
fm added a commit that referenced this pull request Oct 24, 2021
@fm
Copy link
Collaborator

fm commented Oct 24, 2021

Ignore that last revert commit

@baltpeter baltpeter deleted the suggest_fleurop_1634932964949 branch October 24, 2021 11:36
@WebworkrNet
Copy link
Contributor

I miss the obligatory copy of the ID card in the data set.

@baltpeter
Copy link
Member

I miss the obligatory copy of the ID card in the data set.

But it's set correctly:

"needs-id-document": true,

@WebworkrNet
Copy link
Contributor

@baltpeter
I cannot find this additional information either at

@baltpeter
Copy link
Member

Yes, currently that field isn't used anywhere by the website. The reason is that we're planning to add support for attaching ID documents directly in our generator but haven't gotten around that yet.

Now you might say that we could just display a hint in the meantime but we would consider that to be dangerous. Even in the (relative rare) cases where it is legal for a controller to require an ID document for verification, it is never legal to require the full document. There will always be values on the ID document that can (and absolutely should) be redacted by the user. We will only start displaying a hint like that once we also have data on which values on the ID document can be redacted, so we can display that alongside the hint.
See the second item in #690 for some first thoughts on how to implement that.

But to be honest, this feature is pretty low on our priority list at the moment. Our interpretation of the law is that a controller may only require an ID copy in rare cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

5 participants