Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'intan media services GmbH' (community contribution) #1548

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit

"commerce"
],
"name": "intan media services GmbH",
"address": "Blumenhaller Weg 88, 49078 Osnabrück",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Blumenhaller Weg 88, 49078 Osnabrück",
"address": "Blumenhaller Weg 88\n49078 Osnabrück",

"commerce"
],
"name": "intan media services GmbH",
"address": "Blumenhaller Weg 88, 49078 Osnabrück",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Blumenhaller Weg 88, 49078 Osnabrück) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

@baltpeter baltpeter self-assigned this Dec 19, 2021
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 8272a7e into datenanfragen:master Dec 19, 2021
@baltpeter baltpeter deleted the suggest_intan_1636827012896 branch December 19, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants