Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Kollmann Informatik GmbH' (community contribution) #1558

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_kollmann-informatik-gmbh_1637400549815 branch from 46c8242 to e9373fb Compare November 20, 2021 09:29
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Nov 20, 2021
"credit agency"
],
"name": "Kollmann Informatik GmbH",
"address": "Brookkehre 34\n21029 Hamburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (21029 Hamburg) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

],
"name": "Kollmann Informatik GmbH",
"address": "Brookkehre 34\n21029 Hamburg",
"phone": "040/72410310",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "040/72410310"
}

"name": "Kollmann Informatik GmbH",
"address": "Brookkehre 34\n21029 Hamburg",
"phone": "040/72410310",
"fax": "040/72410311",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”

Raw error:

{
    "path": "$.fax",
    "pointer": "/fax",
    "message": "The value at /fax is an invalid string.",
    "data": "040/72410311"
}

@fm
Copy link
Collaborator

fm commented Dec 5, 2021

@baltpeter Website is blank http://kollmanninformatik.de - not sure where the data was gathered from

@baltpeter
Copy link
Member

Seems like the data was taken from GENIOS: https://www.genios.de/firmen/firma/KO/kollmann-informatik-gmbh.html

That is an acceptable source imo. But this really doesn't seem to be a credit agency.

@baltpeter baltpeter self-assigned this Dec 19, 2021
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit fac278e into datenanfragen:master Dec 19, 2021
@baltpeter baltpeter deleted the suggest_kollmann-informatik-gmbh_1637400549815 branch December 19, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

4 participants