Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Kirche Jesu Christi der Heiligen der Letzten Tage' (community contribution) #1564

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Dec 4, 2021
@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_kirche-jesu-christi-der-heiligen-der-letzten-tage_1638626271659 branch from ac855ab to 419934c Compare December 4, 2021 13:57
"runs": [
"FamilySearch"
],
"address": "Data Privacy Office \n50 E. North Temple Street \nSalt Lake City, UT 84150-0005 \nUSA",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (USA) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"runs": [
"FamilySearch"
],
"address": "Data Privacy Office \n50 E. North Temple Street \nSalt Lake City, UT 84150-0005 \nUSA",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address aren't trimmed (at least one line contains trailing or leading whitespace).

Suggested change
"address": "Data Privacy Office \n50 E. North Temple Street \nSalt Lake City, UT 84150-0005 \nUSA",
"address": "Data Privacy Office\n50 E. North Temple Street\nSalt Lake City, UT 84150-0005\nUSA",

@baltpeter baltpeter self-assigned this Dec 19, 2021
…son to the-church-of-jesus-christ-of-latter-day-saints.json
"FamilySearch",
"Kirche Jesu Christi der Heiligen der Letzten Tage"
],
"address": "50 E. North Temple Street\nSalt Lake City, UT 84150-0005\nUSA",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (USA) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 0adbab9 into datenanfragen:master Dec 19, 2021
@baltpeter baltpeter deleted the suggest_kirche-jesu-christi-der-heiligen-der-letzten-tage_1638626271659 branch December 19, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants