Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Justizvollzugsanstalt Frankfurt am Main III' (community contribution) #1634

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Jan 24, 2022
…m-main-iii.json

Match slug in json with filename
@m-rey
Copy link
Collaborator

m-rey commented Jan 24, 2022

I've fixed some small things, but please do review again to be sure. (My last entry review was some time ago.)
Thanks!

companies/justizvollzugsanstalt-frankfurt-am-main-iii.json Outdated Show resolved Hide resolved
"https://justizvollzug.hessen.de/datenschutz",
"https://github.com/datenanfragen/data/pull/1634"
],
"required-elements": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know where these came from? Are they a guess?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't understand. What do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry. I meant whether we know how the required elements were determined. Did the person who submitted this guess which elements are necessary? Or maybe they know that from a previous requests/the privacy policy/…

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the default guess to me, but I don't know for sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's one of these cases with community suggestions where it's unfortunately hard to determine what the right thing to do is. :/ I for one really can't adequately guess what reasonable required elements for correctional facilities are and if the submitter also just guessed, it might be better to remove them and just fall back to the defaults?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. As (afaik) we don't have much/any experience with requests to correctional facilites, I'd suggest falling back to the defaults for now. We'll be able to revise the required elements once we have more data on this.

Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 939035d into datenanfragen:master Feb 5, 2022
@baltpeter baltpeter deleted the suggest_justizvollzug-hessen_1643057732295 branch February 5, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

4 participants