New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Justizvollzugsanstalt Frankfurt am Main III' (community contribution) #1634
Add 'Justizvollzugsanstalt Frankfurt am Main III' (community contribution) #1634
Conversation
c12f8b1
to
161669d
Compare
…m-main-iii.json Match slug in json with filename
|
I've fixed some small things, but please do review again to be sure. (My last entry review was some time ago.) |
| "https://justizvollzug.hessen.de/datenschutz", | ||
| "https://github.com/datenanfragen/data/pull/1634" | ||
| ], | ||
| "required-elements": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know where these came from? Are they a guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I don't understand. What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry. I meant whether we know how the required elements were determined. Did the person who submitted this guess which elements are necessary? Or maybe they know that from a previous requests/the privacy policy/…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the default guess to me, but I don't know for sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's one of these cases with community suggestions where it's unfortunately hard to determine what the right thing to do is. :/ I for one really can't adequately guess what reasonable required elements for correctional facilities are and if the submitter also just guessed, it might be better to remove them and just fall back to the defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. As (afaik) we don't have much/any experience with requests to correctional facilites, I'd suggest falling back to the defaults for now. We'll be able to revise the required elements once we have more data on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This suggestion was submitted through the website.
Edit in company JSON generator