Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Büromarkt Böttcher AG' (community contribution) #1677

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"commerce"
],
"name": "Büromarkt Böttcher AG",
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (07747 Jena) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena",
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena\nGermany",
Suggested change
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena",
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena\nDeutschland",
Suggested change
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena",
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena\nUnited States of America",

"commerce"
],
"name": "Büromarkt Böttcher AG",
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "zu Hd. Datenschutzbeauftragter\nBüromarkt Böttcher AG\nBrüsseler Str. 3\n07747 Jena",
"address": "zu Hd. Datenschutzbeauftragter\nBrüsseler Str. 3\n07747 Jena",

@baltpeter baltpeter self-assigned this May 19, 2022
@@ -0,0 +1,25 @@
{
"slug": "boettcher",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <match-filename-slug> reported by reviewdog 🐶
Filename bueromarkt-ag.json does not match slug boettcher.

Either rename the file or change the slug.

Suggested change
"slug": "boettcher",
"slug": "bueromarkt-ag",

Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 03e516a into datenanfragen:master May 19, 2022
@baltpeter baltpeter deleted the suggest_bueromarkt-ag_1645091967069 branch May 19, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants