Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Fast Data Cover S.L.' (community contribution) #1688

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_fast-data-cover-s-l_1646223588800 branch from 3e47692 to 430bd9e Compare March 2, 2022 12:19
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Mar 2, 2022
"addresses"
],
"name": "Fast Data Cover S.L.",
"address": "Avenida Portal de L'angel, 36, Barcelona, 08002 , Barcelona",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Avenida Portal de L'angel, 36, Barcelona, 08002 , Barcelona",
"address": "Avenida Portal de L'angel\n36\nBarcelona\n08002\nBarcelona",

"addresses"
],
"name": "Fast Data Cover S.L.",
"address": "Avenida Portal de L'angel, 36, Barcelona, 08002 , Barcelona",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Avenida Portal de L'angel, 36, Barcelona, 08002 , Barcelona) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

@baltpeter baltpeter self-assigned this May 19, 2022
@@ -0,0 +1,13 @@
{
"slug": "fast-data-cover",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <match-filename-slug> reported by reviewdog 🐶
Filename fast-data-cover-s-l.json does not match slug fast-data-cover.

Either rename the file or change the slug.

Suggested change
"slug": "fast-data-cover",
"slug": "fast-data-cover-s-l",

Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 94998f6 into datenanfragen:master May 19, 2022
@baltpeter baltpeter deleted the suggest_fast-data-cover-s-l_1646223588800 branch May 19, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants