Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'lekker Energie GmbH' (community contribution) #1689

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"utility"
],
"name": "lekker Energie GmbH",
"address": "Invalidenstraße 17 a\n10115 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (10115 Berlin) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Invalidenstraße 17 a\n10115 Berlin",
"address": "Invalidenstraße 17 a\n10115 Berlin\nGermany",
Suggested change
"address": "Invalidenstraße 17 a\n10115 Berlin",
"address": "Invalidenstraße 17 a\n10115 Berlin\nDeutschland",
Suggested change
"address": "Invalidenstraße 17 a\n10115 Berlin",
"address": "Invalidenstraße 17 a\n10115 Berlin\nUnited States of America",

],
"name": "lekker Energie GmbH",
"address": "Invalidenstraße 17 a\n10115 Berlin",
"phone": "030 - 30 80 99 77",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "030 - 30 80 99 77"
}

"name": "lekker Energie GmbH",
"address": "Invalidenstraße 17 a\n10115 Berlin",
"phone": "030 - 30 80 99 77",
"fax": "030 - 430 949 498",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”

Raw error:

{
    "path": "$.fax",
    "pointer": "/fax",
    "message": "The value at /fax is an invalid string.",
    "data": "030 - 430 949 498"
}

@baltpeter baltpeter self-assigned this May 19, 2022
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 665e725 into datenanfragen:master May 19, 2022
@baltpeter baltpeter deleted the suggest_lekker_1646312647173 branch May 19, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants