Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'All Travel Marketing GmbH' (community contribution) #1707

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_all-travel-marketing-gmbh_1647777546021 branch from 9e660df to f6b38e5 Compare March 20, 2022 11:59
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Mar 20, 2022
"RoBeSt Media UG",
"Reise-Rebellen GmbH"
],
"address": "Maarstr. 84, D-53227 Bonn",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Maarstr. 84, D-53227 Bonn",
"address": "Maarstr. 84\nD-53227 Bonn",

"RoBeSt Media UG",
"Reise-Rebellen GmbH"
],
"address": "Maarstr. 84, D-53227 Bonn",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Maarstr. 84, D-53227 Bonn) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

@baltpeter baltpeter self-assigned this May 19, 2022
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 277d5b3 into datenanfragen:master May 19, 2022
@baltpeter baltpeter deleted the suggest_all-travel-marketing-gmbh_1647777546021 branch May 19, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants