Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Cognosphere Pte. Ltd.' (community contribution) #1717

Conversation

datenanfragen-community-edits
Copy link
Collaborator

@datenanfragen-community-edits datenanfragen-community-edits commented Apr 10, 2022

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"miHoYo Co., Ltd."
],
"address": "C/O: SINGAPORE FOZL GROUP PTE. LTD. 6 Raffles Quay Singapore, 048580 Singapore",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "C/O: SINGAPORE FOZL GROUP PTE. LTD. 6 Raffles Quay Singapore, 048580 Singapore",
"address": "C/O: SINGAPORE FOZL GROUP PTE. LTD. 6 Raffles Quay Singapore\n048580 Singapore",

"runs": [
"miHoYo Co., Ltd."
],
"address": "C/O: SINGAPORE FOZL GROUP PTE. LTD. 6 Raffles Quay Singapore, 048580 Singapore",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (C/O: SINGAPORE FOZL GROUP PTE. LTD. 6 Raffles Quay Singapore, 048580 Singapore) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

Comment on lines 21 to 31
"required-elements": [
{
"desc": "HoYoverse-Pass-ID",
"type": "input",
"optional": false
},
{
"desc": "Zur Account-Registrierung genutzte Email",
"type": "email"
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [companylint] <name-in-required-elements> reported by reviewdog 🐶
Record has required elements but no name element.

@baltpeter baltpeter self-assigned this May 20, 2022
"runs": [
"HoYoverse",
"Genshin Impact"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
],
"address": "C/O: SINGAPORE FOZL GROUP PTE. LTD. 6 Raffles Quay Singapore\n048580 Singapore",

"runs": [
"HoYoverse",
"Genshin Impact"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (C/O: SINGAPORE FOZL GROUP PTE. LTD. 6 Raffles Quay Singapore, 048580 Singapore) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 17e5ca2 into datenanfragen:master May 20, 2022
@baltpeter baltpeter deleted the suggest_cognosphere_1649582210282 branch May 20, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

3 participants