Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Griesson - de Beukelaer GmbH & Co. KG' (community contribution) #1719

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_griesson-de-beukelaer-gmbh-co-kg_1649658887905 branch from e78f51c to 26eb881 Compare April 11, 2022 06:34
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Apr 11, 2022
"all"
],
"name": "Griesson - de Beukelaer GmbH & Co. KG",
"address": "Griesson - de Beukelaer GmbH & Co. KG\nAugust-Horch-Str. 23\n56751 Polch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (56751 Polch) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Griesson - de Beukelaer GmbH & Co. KG\nAugust-Horch-Str. 23\n56751 Polch",
"address": "Griesson - de Beukelaer GmbH & Co. KG\nAugust-Horch-Str. 23\n56751 Polch\nGermany",
Suggested change
"address": "Griesson - de Beukelaer GmbH & Co. KG\nAugust-Horch-Str. 23\n56751 Polch",
"address": "Griesson - de Beukelaer GmbH & Co. KG\nAugust-Horch-Str. 23\n56751 Polch\nDeutschland",

"all"
],
"name": "Griesson - de Beukelaer GmbH & Co. KG",
"address": "Griesson - de Beukelaer GmbH & Co. KG\nAugust-Horch-Str. 23\n56751 Polch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "Griesson - de Beukelaer GmbH & Co. KG\nAugust-Horch-Str. 23\n56751 Polch",
"address": "August-Horch-Str. 23\n56751 Polch",

@baltpeter baltpeter self-assigned this May 22, 2022
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit dc71d07 into datenanfragen:master May 22, 2022
@baltpeter baltpeter deleted the suggest_griesson-de-beukelaer-gmbh-co-kg_1649658887905 branch May 22, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants