Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'SOLIT Management GmbH' (community contribution) #1724

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"finance"
],
"name": "SOLIT Management GmbH",
"address": "Otto-von-Guericke-Ring 10\nD-65205 Wiesbaden",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (D-65205 Wiesbaden) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Otto-von-Guericke-Ring 10\nD-65205 Wiesbaden",
"address": "Otto-von-Guericke-Ring 10\nD-65205 Wiesbaden\nGermany",
Suggested change
"address": "Otto-von-Guericke-Ring 10\nD-65205 Wiesbaden",
"address": "Otto-von-Guericke-Ring 10\nD-65205 Wiesbaden\nDeutschland",

@@ -0,0 +1,18 @@
{
"slug": "solit-kapital",
"relevant-countries": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /relevant-countries must have 1 or more items but it has 0.”

Raw error:

{
    "path": "$.relevant-countries",
    "pointer": "/relevant-countries",
    "message": "The value at /relevant-countries must have 1 or more items but it has 0.",
    "data": []
}

@mal-tee mal-tee self-assigned this Apr 23, 2022
@mal-tee mal-tee enabled auto-merge (squash) May 22, 2022 09:50
@mal-tee mal-tee merged commit 87b6ab0 into datenanfragen:master May 22, 2022
Copy link
Member

@mal-tee mal-tee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mal-tee mal-tee deleted the suggest_solit-kapital_1650704346853 branch May 22, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants