Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Apotheke Zur Rose' (community contribution) #1739

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels May 19, 2022
"de"
],
"name": "Apotheke Zur Rose",
"address": "Thüringer Str. 29 06112 Halle (Saale)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

"de"
],
"name": "Apotheke Zur Rose",
"address": "Thüringer Str. 29 06112 Halle (Saale)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Thüringer Str. 29 06112 Halle (Saale)) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"name": "Apotheke Zur Rose",
"address": "Thüringer Str. 29 06112 Halle (Saale)",
"sources": [
"www.zurrose.de",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /sources/0 must be a valid URI string but it was not.”

Raw error:

{
    "path": "$.sources[0]",
    "pointer": "/sources/0",
    "message": "The value at /sources/0 must be a valid URI string but it was not.",
    "data": "www.zurrose.de"
}

@baltpeter baltpeter self-assigned this May 22, 2022
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 316988e into datenanfragen:master May 22, 2022
@baltpeter baltpeter deleted the suggest_apotheke-zur-rose_1652951412485 branch May 22, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants