Add 'GEFRO GmbH & Co. KG' (community contribution) #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datenanfragen-community-edits
force-pushed
the
suggest_gefro_1654534201353
branch
from
6dd7694
to
a17f25c
Compare
datenanfragen-community-edits
added
record
companies/gefro.json
Outdated
| "commerce" | ||
| ], | ||
| "name": "GEFRO GmbH & Co. KG", | ||
| "address": "Datenschutz\nRudolf-Diesel-Straße 21\n87700 Memmingen", |
There was a problem hiding this comment.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (87700 Memmingen) is not a country.
We've decided on specific variations for these countries:
United States of AmericaThe NetherlandsRepublic of Singapore
Suggested change
| "address": "Datenschutz\nRudolf-Diesel-Straße 21\n87700 Memmingen", | |
| "address": "Datenschutz\nRudolf-Diesel-Straße 21\n87700 Memmingen\nGermany", |
Suggested change
| "address": "Datenschutz\nRudolf-Diesel-Straße 21\n87700 Memmingen", | |
| "address": "Datenschutz\nRudolf-Diesel-Straße 21\n87700 Memmingen\nDeutschland", |
companies/gefro.json
Outdated
| ], | ||
| "name": "GEFRO GmbH & Co. KG", | ||
| "address": "Datenschutz\nRudolf-Diesel-Straße 21\n87700 Memmingen", | ||
| "phone": "08331/95950", |
There was a problem hiding this comment.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”
Raw error:
{
"path": "$.phone",
"pointer": "/phone",
"message": "The value at /phone is an invalid string.",
"data": "08331/95950"
}
companies/gefro.json
Outdated
| "name": "GEFRO GmbH & Co. KG", | ||
| "address": "Datenschutz\nRudolf-Diesel-Straße 21\n87700 Memmingen", | ||
| "phone": "08331/95950", | ||
| "fax": "08331/9595-17", |
There was a problem hiding this comment.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”
Raw error:
{
"path": "$.fax",
"pointer": "/fax",
"message": "The value at /fax is an invalid string.",
"data": "08331/9595-17"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suggestion was submitted through the website.
Edit in company JSON generator