Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'wirkaufendeinauto.de GmbH' (community contribution) #1778

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Jun 15, 2022
"de"
],
"name": "wirkaufendeinauto.de GmbH",
"address": "Potsdamer Platz\n110785 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (110785 Berlin) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Potsdamer Platz\n110785 Berlin",
"address": "Potsdamer Platz\n110785 Berlin\nGermany",
Suggested change
"address": "Potsdamer Platz\n110785 Berlin",
"address": "Potsdamer Platz\n110785 Berlin\nDeutschland",
Suggested change
"address": "Potsdamer Platz\n110785 Berlin",
"address": "Potsdamer Platz\n110785 Berlin\nUnited States of America",

],
"name": "wirkaufendeinauto.de GmbH",
"address": "Potsdamer Platz\n110785 Berlin",
"phone": "00493020163290",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "00493020163290"
}

Comment on lines 15 to 20
"required-elements": [
{
"desc": "E-Mail",
"type": "email"
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [companylint] <name-in-required-elements> reported by reviewdog 🐶
Record has required elements but no name element.

@baltpeter baltpeter enabled auto-merge (squash) August 29, 2023 16:35
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit e4daae1 into datenanfragen:master Aug 29, 2023
2 checks passed
@baltpeter baltpeter deleted the suggest_wirkaufendeinauto_1655315481519 branch August 29, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants