Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'My Corona Check-Schnelltestzentrum München' (community contribution) #1791

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_mycoronacheck-probatix_1656071109434 branch from 60a3248 to 5518f86 Compare June 24, 2022 11:45
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Jun 24, 2022
"health"
],
"name": "My Corona Check-Schnelltestzentrum München",
"address": "Prinzregentenstraße 90, 81675 München",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Prinzregentenstraße 90, 81675 München",
"address": "Prinzregentenstraße 90\n81675 München",

"health"
],
"name": "My Corona Check-Schnelltestzentrum München",
"address": "Prinzregentenstraße 90, 81675 München",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Prinzregentenstraße 90, 81675 München) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

],
"name": "My Corona Check-Schnelltestzentrum München",
"address": "Prinzregentenstraße 90, 81675 München",
"phone": "089 9544 8520",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "089 9544 8520"
}

"name": "My Corona Check-Schnelltestzentrum München",
"address": "Prinzregentenstraße 90, 81675 München",
"phone": "089 9544 8520",
"email": "muenchen@mycoronacheck.de (Betreiber), datenschutz@probatix.de",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /email must be a valid idn-email string but it was not.”

Raw error:

{
    "path": "$.email",
    "pointer": "/email",
    "message": "The value at /email must be a valid idn-email string but it was not.",
    "data": "muenchen@mycoronacheck.de (Betreiber),  datenschutz@probatix.de"
}

@mal-tee mal-tee enabled auto-merge (squash) August 29, 2023 20:25
mal-tee
mal-tee previously approved these changes Aug 29, 2023
Copy link
Member

@mal-tee mal-tee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mal-tee mal-tee disabled auto-merge August 29, 2023 20:28
@mal-tee mal-tee enabled auto-merge (squash) August 29, 2023 20:29
@mal-tee mal-tee merged commit 4d574f8 into datenanfragen:master Aug 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants