Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'RTL interactive GmbH' (community contribution) #1840

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_rtl-television-gmbh_1659951732486 branch from c6647b0 to 1cba6f0 Compare August 8, 2022 09:42
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Aug 8, 2022
"runs": [
"tvnow.de"
],
"address": "Picassoplatz 1\n50679 Köln",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (50679 Köln) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Picassoplatz 1\n50679 Köln",
"address": "Picassoplatz 1\n50679 Köln\nGermany",
Suggested change
"address": "Picassoplatz 1\n50679 Köln",
"address": "Picassoplatz 1\n50679 Köln\nDeutschland",

"phone": "+49 221 45662999",
"fax": "+49 221 45662993",
"sources": [
"tvnow.de/impressum",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /sources/0 must be a valid URI string but it was not.”

Raw error:

{
    "path": "$.sources[0]",
    "pointer": "/sources/0",
    "message": "The value at /sources/0 must be a valid URI string but it was not.",
    "data": "tvnow.de/impressum"
}

@baltpeter baltpeter changed the title Add 'RTL Television GmbH' (community contribution) Add 'RTL interactive GmbH' (community contribution) Sep 5, 2023
@baltpeter baltpeter enabled auto-merge (squash) September 5, 2023 07:26
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 65fad44 into datenanfragen:master Sep 5, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_rtl-television-gmbh_1659951732486 branch September 5, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants