Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Online Commerce Limited' (community contribution) #1847

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_online-commerce-limited_1660472709462 branch from 43ff1dc to 7feb658 Compare August 14, 2022 10:25
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Aug 14, 2022
"runs": [
"base.com"
],
"address": "Online Commerce Limited\n1 A P Ellis Road\nUpper Rissington\nCheltenham\nGL54 2QB",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (GL54 2QB) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"runs": [
"base.com"
],
"address": "Online Commerce Limited\n1 A P Ellis Road\nUpper Rissington\nCheltenham\nGL54 2QB",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "Online Commerce Limited\n1 A P Ellis Road\nUpper Rissington\nCheltenham\nGL54 2QB",
"address": "1 A P Ellis Road\nUpper Rissington\nCheltenham\nGL54 2QB",

@baltpeter baltpeter enabled auto-merge (squash) September 5, 2023 08:01
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit eefd25f into datenanfragen:master Sep 5, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_online-commerce-limited_1660472709462 branch September 5, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants