Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'GORILLAS' (community contribution) #1849

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"gorillas.io"
],
"address": "Saarbrücker Straße 36 \n10405 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (10405 Berlin) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Saarbrücker Straße 36 \n10405 Berlin",
"address": "Saarbrücker Straße 36 \n10405 Berlin\nGermany",
Suggested change
"address": "Saarbrücker Straße 36 \n10405 Berlin",
"address": "Saarbrücker Straße 36 \n10405 Berlin\nDeutschland",
Suggested change
"address": "Saarbrücker Straße 36 \n10405 Berlin",
"address": "Saarbrücker Straße 36 \n10405 Berlin\nUnited States of America",

"gorillas.io"
],
"address": "Saarbrücker Straße 36 \n10405 Berlin",
"phone": "030 23591 8698",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "030 23591 8698"
}

],
"address": "Saarbrücker Straße 36 \n10405 Berlin",
"phone": "030 23591 8698",
"fax": "030 23591 8699",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”

Raw error:

{
    "path": "$.fax",
    "pointer": "/fax",
    "message": "The value at /fax is an invalid string.",
    "data": "030 23591 8699"
}

"runs": [
"gorillas.io"
],
"address": "Saarbrücker Straße 36 \n10405 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address aren't trimmed (at least one line contains trailing or leading whitespace).

Suggested change
"address": "Saarbrücker Straße 36 \n10405 Berlin",
"address": "Saarbrücker Straße 36\n10405 Berlin",

@baltpeter baltpeter changed the title Add 'Gorillas Operations Germany B.V. & Co KG' (community contribution) Add 'GORILLAS' (community contribution) Sep 5, 2023
@baltpeter baltpeter enabled auto-merge (squash) September 5, 2023 08:16
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 793c495 into datenanfragen:master Sep 5, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_gorillas_1660733389392 branch September 5, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants