New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'GORILLAS' (community contribution) #1849
Add 'GORILLAS' (community contribution) #1849
Conversation
404f462
to
45d27f3
Compare
companies/gorillas.json
Outdated
"runs": [ | ||
"gorillas.io" | ||
], | ||
"address": "Saarbrücker Straße 36 \n10405 Berlin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address
(10405 Berlin
) is not a country.
We've decided on specific variations for these countries:
United States of America
The Netherlands
Republic of Singapore
"address": "Saarbrücker Straße 36 \n10405 Berlin", | |
"address": "Saarbrücker Straße 36 \n10405 Berlin\nGermany", |
"address": "Saarbrücker Straße 36 \n10405 Berlin", | |
"address": "Saarbrücker Straße 36 \n10405 Berlin\nDeutschland", |
"address": "Saarbrücker Straße 36 \n10405 Berlin", | |
"address": "Saarbrücker Straße 36 \n10405 Berlin\nUnited States of America", |
companies/gorillas.json
Outdated
"gorillas.io" | ||
], | ||
"address": "Saarbrücker Straße 36 \n10405 Berlin", | ||
"phone": "030 23591 8698", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”
Raw error:
{
"path": "$.phone",
"pointer": "/phone",
"message": "The value at /phone is an invalid string.",
"data": "030 23591 8698"
}
companies/gorillas.json
Outdated
], | ||
"address": "Saarbrücker Straße 36 \n10405 Berlin", | ||
"phone": "030 23591 8698", | ||
"fax": "030 23591 8699", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”
Raw error:
{
"path": "$.fax",
"pointer": "/fax",
"message": "The value at /fax is an invalid string.",
"data": "030 23591 8699"
}
companies/gorillas.json
Outdated
"runs": [ | ||
"gorillas.io" | ||
], | ||
"address": "Saarbrücker Straße 36 \n10405 Berlin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address
aren't trimmed (at least one line contains trailing or leading whitespace).
"address": "Saarbrücker Straße 36 \n10405 Berlin", | |
"address": "Saarbrücker Straße 36\n10405 Berlin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This suggestion was submitted through the website.
Edit in company JSON generator