Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'DER Touristik Deutschland GmbH' (community contribution) #1854

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"travel"
],
"name": "DER Touristik Deutschland GmbH",
"address": "Humboldtstraße 140\n51149 Köln",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (51149 Köln) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Humboldtstraße 140\n51149 Köln",
"address": "Humboldtstraße 140\n51149 Köln\nGermany",
Suggested change
"address": "Humboldtstraße 140\n51149 Köln",
"address": "Humboldtstraße 140\n51149 Köln\nDeutschland",

"email": "datenschutz@dertouristik.com",
"web": "https://www.dertour.de/ibecontent/datenschutz",
"sources": [
"Unternehmenswebseite, Unterseite Datenschutz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /sources/0 must be a valid URI string but it was not.”

Raw error:

{
    "path": "$.sources[0]",
    "pointer": "/sources/0",
    "message": "The value at /sources/0 must be a valid URI string but it was not.",
    "data": "Unternehmenswebseite, Unterseite Datenschutz"
}

@baltpeter baltpeter enabled auto-merge (squash) September 5, 2023 08:24
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 017c784 into datenanfragen:master Sep 5, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_dertour_1661378469593 branch September 5, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants