Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Nurme Kool' (community contribution) #1943

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"all"
],
"name": "Nurme Kool",
"address": "Tallinna 46, Paide, 72711 Järva maakond",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Tallinna 46, Paide, 72711 Järva maakond",
"address": "Tallinna 46\nPaide\n72711 Järva maakond",

"all"
],
"name": "Nurme Kool",
"address": "Tallinna 46, Paide, 72711 Järva maakond",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Tallinna 46, Paide, 72711 Järva maakond) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

],
"name": "Nurme Kool",
"address": "Tallinna 46, Paide, 72711 Järva maakond",
"phone": "386 9434",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "386 9434"
}

@baltpeter baltpeter enabled auto-merge (squash) September 21, 2023 10:05
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit d57eb39 into datenanfragen:master Sep 21, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_nurmekool-edu_1668688363236 branch September 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants