Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'marbis GmbH' (community contribution) #1965

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"nitrado"
],
"address": "marbis GmbH\nGriesbachstraße 10\n76185 Karlsruhe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (76185 Karlsruhe) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "marbis GmbH\nGriesbachstraße 10\n76185 Karlsruhe",
"address": "marbis GmbH\nGriesbachstraße 10\n76185 Karlsruhe\nGermany",
Suggested change
"address": "marbis GmbH\nGriesbachstraße 10\n76185 Karlsruhe",
"address": "marbis GmbH\nGriesbachstraße 10\n76185 Karlsruhe\nDeutschland",

"runs": [
"nitrado"
],
"address": "marbis GmbH\nGriesbachstraße 10\n76185 Karlsruhe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "marbis GmbH\nGriesbachstraße 10\n76185 Karlsruhe",
"address": "Griesbachstraße 10\n76185 Karlsruhe",

@baltpeter baltpeter enabled auto-merge (squash) September 21, 2023 10:52
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit bbed0f3 into datenanfragen:master Sep 21, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_nitrado_1669834687821 branch September 21, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants