Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Salcar GmbH' (community contribution) #1974

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

],
"name": "Salcar GmbH",
"runs": [],
"address": "An der Hebemärchte 6\n04316 Leipzig",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (04316 Leipzig) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "An der Hebemärchte 6\n04316 Leipzig",
"address": "An der Hebemärchte 6\n04316 Leipzig\nGermany",
Suggested change
"address": "An der Hebemärchte 6\n04316 Leipzig",
"address": "An der Hebemärchte 6\n04316 Leipzig\nDeutschland",

"name": "Salcar GmbH",
"runs": [],
"address": "An der Hebemärchte 6\n04316 Leipzig",
"phone": "03412025321238",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "03412025321238"
}

"email": "info@sekeymall.com",
"web": "https://www.sekeymall.com",
"sources": [
"www.sekeymall.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /sources/0 must be a valid URI string but it was not.”

Raw error:

{
    "path": "$.sources[0]",
    "pointer": "/sources/0",
    "message": "The value at /sources/0 must be a valid URI string but it was not.",
    "data": "www.sekeymall.com"
}

@baltpeter baltpeter enabled auto-merge (squash) September 21, 2023 11:15
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit ae2f1a0 into datenanfragen:master Sep 21, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_sekeymall_1670194561886 branch September 21, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants