Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Salo Holding AG' (community contribution) #1975

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"school"
],
"name": "Salo Holding AG",
"address": "Spaldingstraße 57-59\n20097 Hamburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (20097 Hamburg) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Spaldingstraße 57-59\n20097 Hamburg",
"address": "Spaldingstraße 57-59\n20097 Hamburg\nGermany",
Suggested change
"address": "Spaldingstraße 57-59\n20097 Hamburg",
"address": "Spaldingstraße 57-59\n20097 Hamburg\nDeutschland",
Suggested change
"address": "Spaldingstraße 57-59\n20097 Hamburg",
"address": "Spaldingstraße 57-59\n20097 Hamburg\nUnited States of America",

],
"name": "Salo Holding AG",
"address": "Spaldingstraße 57-59\n20097 Hamburg",
"phone": "040 239160",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "040 239160"
}

@baltpeter baltpeter enabled auto-merge (squash) September 21, 2023 11:19
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 51a3052 into datenanfragen:master Sep 21, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_salo-holding-ag_1670232365410 branch September 21, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants