New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Salo Holding AG' (community contribution) #1975
Add 'Salo Holding AG' (community contribution) #1975
Conversation
b0c6393
to
2e301fc
Compare
companies/salo-holding-ag.json
Outdated
"school" | ||
], | ||
"name": "Salo Holding AG", | ||
"address": "Spaldingstraße 57-59\n20097 Hamburg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address
(20097 Hamburg
) is not a country.
We've decided on specific variations for these countries:
United States of America
The Netherlands
Republic of Singapore
"address": "Spaldingstraße 57-59\n20097 Hamburg", | |
"address": "Spaldingstraße 57-59\n20097 Hamburg\nGermany", |
"address": "Spaldingstraße 57-59\n20097 Hamburg", | |
"address": "Spaldingstraße 57-59\n20097 Hamburg\nDeutschland", |
"address": "Spaldingstraße 57-59\n20097 Hamburg", | |
"address": "Spaldingstraße 57-59\n20097 Hamburg\nUnited States of America", |
companies/salo-holding-ag.json
Outdated
], | ||
"name": "Salo Holding AG", | ||
"address": "Spaldingstraße 57-59\n20097 Hamburg", | ||
"phone": "040 239160", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”
Raw error:
{
"path": "$.phone",
"pointer": "/phone",
"message": "The value at /phone is an invalid string.",
"data": "040 239160"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This suggestion was submitted through the website.
Edit in company JSON generator