Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Vanderstorm Ventures GmbH & Co. KG' (community contribution) #1981

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Dec 8, 2022
@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_vanderstorm-ventures-gmbh-co-kg_1670493645622 branch from e2d2e44 to 31063b3 Compare December 8, 2022 10:00
],
"name": "Vanderstorm Ventures GmbH & Co. KG",
"runs": [],
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (10832 Berlin) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin",
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin\nGermany",
Suggested change
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin",
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin\nDeutschland",
Suggested change
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin",
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin\nUnited States of America",

],
"name": "Vanderstorm Ventures GmbH & Co. KG",
"runs": [],
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "Vanderstorm Ventures GmbH & Co. KG\nPostfach 110207\n10832 Berlin",
"address": "Postfach 110207\n10832 Berlin",

@baltpeter baltpeter enabled auto-merge (squash) September 22, 2023 08:10
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 46125e4 into datenanfragen:master Sep 22, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_vanderstorm-ventures-gmbh-co-kg_1670493645622 branch September 22, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants