Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'SEBA Bank AG' (community contribution) #2001

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"finance"
],
"name": "SEBA Bank AG",
"address": "Kolinplatz 15, 6300 Zug, Switzerland",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Kolinplatz 15, 6300 Zug, Switzerland",
"address": "Kolinplatz 15\n6300 Zug\nSwitzerland",

"finance"
],
"name": "SEBA Bank AG",
"address": "Kolinplatz 15, 6300 Zug, Switzerland",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Kolinplatz 15, 6300 Zug, Switzerland) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

@baltpeter baltpeter enabled auto-merge (squash) September 22, 2023 08:25
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit cbe929f into datenanfragen:master Sep 22, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_seba_1671448274118 branch September 22, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants