Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'EWE VERTRIEB GmbH' (community contribution) #2034

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"utility"
],
"name": "EWE VERTRIEB GmbH",
"address": "Cloppenburger Str. 310\n26133 Oldenburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (26133 Oldenburg) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Cloppenburger Str. 310\n26133 Oldenburg",
"address": "Cloppenburger Str. 310\n26133 Oldenburg\nGermany",
Suggested change
"address": "Cloppenburger Str. 310\n26133 Oldenburg",
"address": "Cloppenburger Str. 310\n26133 Oldenburg\nDeutschland",

],
"name": "EWE VERTRIEB GmbH",
"address": "Cloppenburger Str. 310\n26133 Oldenburg",
"phone": "044180005555",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "044180005555"
}

@baltpeter baltpeter enabled auto-merge (squash) September 22, 2023 10:16
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit af66902 into datenanfragen:master Sep 22, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_ewe_1672756758779 branch September 22, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants