Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'mvneco GmbH' (community contribution) #2052

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"Vodafone Sales App"
],
"address": "Oberbilker Allee 165\nD-40227 Düsseldorf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (D-40227 Düsseldorf) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Oberbilker Allee 165\nD-40227 Düsseldorf",
"address": "Oberbilker Allee 165\nD-40227 Düsseldorf\nGermany",
Suggested change
"address": "Oberbilker Allee 165\nD-40227 Düsseldorf",
"address": "Oberbilker Allee 165\nD-40227 Düsseldorf\nDeutschland",

@baltpeter baltpeter enabled auto-merge (squash) September 22, 2023 10:38
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 30f46d7 into datenanfragen:master Sep 22, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_mvneco_1673442233375 branch September 22, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants