Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'FFG FINANZCHECK Finanzportale GmbH' (community contribution) #2053

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_ffg-finanzcheck-finanzportale-gmbh_1673474251100 branch from 2b0f429 to 3609404 Compare January 11, 2023 21:57
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Jan 11, 2023
"finance"
],
"name": "FFG FINANZCHECK Finanzportale GmbH",
"address": "Admiralitätstraße 60\n20459 Hamburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (20459 Hamburg) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Admiralitätstraße 60\n20459 Hamburg",
"address": "Admiralitätstraße 60\n20459 Hamburg\nGermany",
Suggested change
"address": "Admiralitätstraße 60\n20459 Hamburg",
"address": "Admiralitätstraße 60\n20459 Hamburg\nDeutschland",
Suggested change
"address": "Admiralitätstraße 60\n20459 Hamburg",
"address": "Admiralitätstraße 60\n20459 Hamburg\nUnited States of America",

],
"name": "FFG FINANZCHECK Finanzportale GmbH",
"address": "Admiralitätstraße 60\n20459 Hamburg",
"suggested-transport-medium": "email",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <suggested-medium-exists> reported by reviewdog 🐶
Suggested-transport-medium is set to 'email', but the email is not defined in the record.

@baltpeter baltpeter enabled auto-merge (squash) September 22, 2023 10:40
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 4a13dd5 into datenanfragen:master Sep 22, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_ffg-finanzcheck-finanzportale-gmbh_1673474251100 branch September 22, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants