Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'LYNX B.V. Germany Branch' (community contribution) #2106

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"finance"
],
"name": "LYNX B.V. Germany Branch",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (10117 Berlin) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin\nGermany",
Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin\nDeutschland",
Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin\nUnited States of America",

"finance"
],
"name": "LYNX B.V. Germany Branch",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "Zweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",

],
"name": "LYNX B.V. Germany Branch",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"phone": "030-303286690",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "030-303286690"
}

@baltpeter baltpeter enabled auto-merge (squash) September 25, 2023 11:50
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit c41b270 into datenanfragen:master Sep 25, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_lynxbroker_1676391642090 branch September 25, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants