New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Greenpeace Media GmbH' (community contribution) #2108
Add 'Greenpeace Media GmbH' (community contribution) #2108
Conversation
66e5e9c
to
2e8d620
Compare
companies/greenpeace-magazin.json
Outdated
| "de" | ||
| ], | ||
| "name": "Greenpeace Media GmbH", | ||
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (22767 Hamburg) is not a country.
We've decided on specific variations for these countries:
United States of AmericaThe NetherlandsRepublic of Singapore
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", | |
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg\nGermany", |
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", | |
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg\nDeutschland", |
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", | |
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg\nUnited States of America", |
companies/greenpeace-magazin.json
Outdated
| "de" | ||
| ], | ||
| "name": "Greenpeace Media GmbH", | ||
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", | |
| "address": "Große Elbstraße 145 d\n22767 Hamburg", |
companies/greenpeace-magazin.json
Outdated
| ], | ||
| "name": "Greenpeace Media GmbH", | ||
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", | ||
| "phone": "040/808 12 80 80", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”
Raw error:
{
"path": "$.phone",
"pointer": "/phone",
"message": "The value at /phone is an invalid string.",
"data": "040/808 12 80 80"
}
companies/greenpeace-magazin.json
Outdated
| "name": "Greenpeace Media GmbH", | ||
| "address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg", | ||
| "phone": "040/808 12 80 80", | ||
| "fax": "040/808 12 80 99", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”
Raw error:
{
"path": "$.fax",
"pointer": "/fax",
"message": "The value at /fax is an invalid string.",
"data": "040/808 12 80 99"
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This suggestion was submitted through the website.
Edit in company JSON generator