Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Greenpeace Media GmbH' (community contribution) #2108

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Feb 16, 2023
"de"
],
"name": "Greenpeace Media GmbH",
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (22767 Hamburg) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg\nGermany",
Suggested change
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg\nDeutschland",
Suggested change
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg\nUnited States of America",

"de"
],
"name": "Greenpeace Media GmbH",
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
"address": "Große Elbstraße 145 d\n22767 Hamburg",

],
"name": "Greenpeace Media GmbH",
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
"phone": "040/808 12 80 80",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "040/808 12 80 80"
}

"name": "Greenpeace Media GmbH",
"address": "Greenpeace Media GmbH\nGroße Elbstraße 145 d\n22767 Hamburg",
"phone": "040/808 12 80 80",
"fax": "040/808 12 80 99",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”

Raw error:

{
    "path": "$.fax",
    "pointer": "/fax",
    "message": "The value at /fax is an invalid string.",
    "data": "040/808 12 80 99"
}

@baltpeter baltpeter enabled auto-merge (squash) September 25, 2023 12:10
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 11e20f6 into datenanfragen:master Sep 25, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_greenpeace-magazin_1676568027013 branch September 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants