Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'FDP Landesverband Berlin' (community contribution) #2110

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"political party"
],
"name": "FDP-Landesverband Berlin",
"address": "Dorotheenstraße 56, 10117 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Dorotheenstraße 56, 10117 Berlin",
"address": "Dorotheenstraße 56\n10117 Berlin",

"political party"
],
"name": "FDP-Landesverband Berlin",
"address": "Dorotheenstraße 56, 10117 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Dorotheenstraße 56, 10117 Berlin) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

],
"name": "FDP-Landesverband Berlin",
"address": "Dorotheenstraße 56, 10117 Berlin",
"phone": "030 278959-0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "030 278959-0"
}

@baltpeter baltpeter changed the title Add 'FDP-Landesverband Berlin' (community contribution) Add 'FDP Landesverband Berlin' (community contribution) Sep 25, 2023
@baltpeter baltpeter enabled auto-merge (squash) September 25, 2023 12:13
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 2fb0ef7 into datenanfragen:master Sep 25, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_fdp-berlin_1676642511876 branch September 25, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants